Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

CSS Code Hinting for new CodeHintManager-API #2492

Closed
wants to merge 70 commits into from

Conversation

zoufahl
Copy link

@zoufahl zoufahl commented Jan 8, 2013

This extension adds basic CSS Code Hinting for Brackets. (similar to HTML Code Hinting), but uses more keys to trigger the hinting.

It differentiates between primary (alphabet) and secondary (whitespace, (semi-)colon) trigger keys to distinguish whether hints should be selected initially or not.

Works in *.css files and style-blocks in html-files
Does not work in inline-css yet, due to limited tokenizing.

Andre Zoufahl added 30 commits November 4, 2012 15:48
…oblem properly with regards to value-hinting
…-)colon, which caused handleSelect to drop the first letter of the selection
Andre Zoufahl added 20 commits January 5, 2013 20:57
…t key, removed a strange bug, that tokens haven't been trimmed properly in getHints
…ting-v2

merging master into branch for an upcoming pull-request
@RaymondLim
Copy link
Contributor

@zoufahl Thanks for working on this!

You have a long list of commits in this pull request. Can you squash them into a single commit?

The easiest way to do it is to create a new branch off master, check it out, then "git merge --squash andrez/csscodehinting-v2", then submit a pull request off the new branch.

Let me know if you need help in squashing.

@redmunds
Copy link
Contributor

redmunds commented Jan 9, 2013

The extension also need to be moved from the extensions/dev folder to the extensions/default folder. You can probably just close this pull request are create a new one with the files moved, and that will squash everything to a single commit.

@RaymondLim
Copy link
Contributor

@zoufahl One more thing! Your CSS properties list in json file may not be accurate or complete. Can you also check against the following urls and update them? (eg. font-family is missing in there)

http://www.w3.org/TR/CSS/#indices

CSS 3 properties are chunked into several modules:

http://www.w3.org/TR/css3-ui/#property
http://www.w3.org/TR/css3-2d-transforms/#property-index
http://www.w3.org/TR/css3-transitions/#property-index
http://www.w3.org/TR/css3-fonts/#property-index
http://www.w3.org/TR/css3-text/#appendix-f-full-property-index
http://www.w3.org/TR/css3-animations/#property-index
http://www.w3.org/TR/css3-color/#property

@zoufahl
Copy link
Author

zoufahl commented Jan 9, 2013

@RaymondLim I noticed that too today, that the list is incomplete.

@zoufahl zoufahl closed this Jan 9, 2013
@redmunds
Copy link
Contributor

redmunds commented Jan 9, 2013

@zoufahl ,

Thank you for this awesome contribution to Brackets! For this (updated) pull request, we will focus on the CSS Code Hinting mechanism. The CSS information will always be a moving target, so we will improve that in another pull request, and again as necessary. No need to worry about that at this time.

Thanks,
Randy

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants