Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Load extensions before loading project, then fire APP_READY. #2501

Merged
merged 5 commits into from
Jan 11, 2013

Conversation

jasonsanjose
Copy link
Member

Fix for #1951

Change app initialization to load extensions first, then load the project and initialize the working set before firing the APP_READY event. Many thanks to @DennisKehrig.

While cleaning up the startup process, I opportunistically cleaned up a lot of startup code by deferring some initialization out of the module init (implicit and/or explicit) and into APP_READY and HTML_READY handlers as appropriate.

Unit, performance and extension tests are passing.

@ghost ghost assigned dangoor Jan 10, 2013
@dangoor
Copy link
Contributor

dangoor commented Jan 10, 2013

I didn't see anything amiss here. It looks like a nice refactoring. I haven't had a chance to exercise it beyond firing up Brackets and having it run. I'll play around with some more features later on, but it's looking good.

@njx
Copy link
Contributor

njx commented Jan 10, 2013

@dangoor -- fyi, it's better to make comments in the "Files" tab (instead of on individual commits) -- that way all the comments can be viewed in context in one place (and github will show the surrounding code in this "Discussion" tab as well). Kind of a weird workflow issue in github.

@njx
Copy link
Contributor

njx commented Jan 10, 2013

(oops, meant "it's better to make inline comments in the "Files" tab"--other general comments can just go in Discussion)

@jasonsanjose
Copy link
Member Author

Changes pushed. Ready for review @dangoor.

@dangoor
Copy link
Contributor

dangoor commented Jan 11, 2013

@njx thanks for the tip. I made those comments and came back to the pull request page and was a bit puzzled as to why my comments didn't show up with the diffs as it has for others.

@dangoor
Copy link
Contributor

dangoor commented Jan 11, 2013

Looks good to me, and I just tested out a number of features and everything is working fine. I'll merge.

dangoor added a commit that referenced this pull request Jan 11, 2013
Load extensions before loading project, then fire APP_READY.
@dangoor dangoor merged commit 3018b11 into master Jan 11, 2013
@njx
Copy link
Contributor

njx commented Jul 19, 2013

Removing "for release note" label from this old pull request.

@njx
Copy link
Contributor

njx commented Jul 19, 2013

Hmm. Apparently I can't remove the label, even from the summary view. Oh well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants