-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Load extensions before loading project, then fire APP_READY. #2501
Conversation
…present) has been loaded
…ackets initialization.
I didn't see anything amiss here. It looks like a nice refactoring. I haven't had a chance to exercise it beyond firing up Brackets and having it run. I'll play around with some more features later on, but it's looking good. |
@dangoor -- fyi, it's better to make comments in the "Files" tab (instead of on individual commits) -- that way all the comments can be viewed in context in one place (and github will show the surrounding code in this "Discussion" tab as well). Kind of a weird workflow issue in github. |
(oops, meant "it's better to make inline comments in the "Files" tab"--other general comments can just go in Discussion) |
Changes pushed. Ready for review @dangoor. |
@njx thanks for the tip. I made those comments and came back to the pull request page and was a bit puzzled as to why my comments didn't show up with the diffs as it has for others. |
Looks good to me, and I just tested out a number of features and everything is working fine. I'll merge. |
Load extensions before loading project, then fire APP_READY.
Removing "for release note" label from this old pull request. |
Hmm. Apparently I can't remove the label, even from the summary view. Oh well. |
Fix for #1951
Change app initialization to load extensions first, then load the project and initialize the working set before firing the
APP_READY
event. Many thanks to @DennisKehrig.While cleaning up the startup process, I opportunistically cleaned up a lot of startup code by deferring some initialization out of the module init (implicit and/or explicit) and into
APP_READY
andHTML_READY
handlers as appropriate.Unit, performance and extension tests are passing.