This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Implement a navigation command that takes the user to the first JSLint error #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| CommandManager.register( | ||
| Strings.CMD_JSLINT_FIRST_ERROR, | ||
| Commands.NAVIGATE_GOTO_JSLINT_ERROR, | ||
| function () { |
There was a problem hiding this comment.
Minor style nit: this handler function should be extracted, and the arguments should all be on the same line (this helps keep things tidy when you have many commands registered in a single file. See the bottom of DocumentCommandHandlers.js for an example)
|
Done with initial review. Just one minor style nit. |
|
@gruehle Thanks. Fixed. |
ghost
assigned
|
Looks great! Merging. |
gruehle
added a commit
that referenced
this pull request
Jan 14, 2013
Implement a navigation command that takes the user to the first JSLint error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gruehle
Certainly open to changing the keybinding