This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Don't update hint list with changes from the program (like those from hint insertion). #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… hint insertion). Also make sure to check with other providers when a character ends a hinting session.
|
This looks OK to me. In the future it might be useful to elaborate the CHM so that CHPs can indicate, after closing a session, whether or not the CHM should immediately poll other providers, as is already the case after hint insertion. But for now this seems to be reasonable default behavior. |
|
@RaymondLim Ian doesn't have the appropriate privileges to actually merge this pull request. So, I'm merging it. Thanks for the fix! @iwehrman Thanks for the review! |
joelrbrandt
added a commit
that referenced
this pull request
Jan 20, 2013
Don't update hint list with changes from the program (like those from hint insertion).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make sure to check with other providers when a character ends the current hinting session.
This fixes issue #2586 and #2601.
@iwehrman You need to review this pull request. DON'T MERGE IT until Ian has a chance to review.