Fixed: #1997 and #1397 #2685
Fixed: #1997 and #1397 #2685
Conversation
ghost
assigned 
|
Thanks for the code contribution! I've taken a peek at the code, but I also tried running the tests... I see a whole bunch of unit test failures. (66 in EditorCommandHandlers, for example). It might be something simple. Have you tried running the tests? (Make sure you hit Show Developer Tools and have caching turned off via the gear menu in the Chrome developer tools, just to be sure you're not running cached code...) Thanks again. Looks like a good start. |
|
The failures were due to the initialisation of an editor object with the additionalKeys param in the unit tests i cleaned this up and all my unit tests pass so it should work now |
| @@ -54441,7 +54441,7 @@ define('editor/EditorManager',['require','exports','module','file/FileUtils','co | |||
| function _createEditorForDocument(doc, makeMasterEditor, container, range, additionalKeys) { | |||
| var mode = EditorUtils.getModeFromFileExtension(doc.file.fullPath); | |||
|
|
|||
| return new Editor(doc, makeMasterEditor, mode, container, additionalKeys, range); | |||
There was a problem hiding this comment.
We shouldn't modify this file -- it's an old copy of the Brackets source that we use as a performance testcase. We want it frozen so we can compare performance results over time.
|
@peterflynn I restored the file |
|
I just spotted one more editor that slipped through: HTMLCodeHints/unittests.js has a call with the additional keys parameter (extension tests don't run as part of the main suite, but you can run them by clicking on Extensions in the test runner). With that change, I think the #1397 fixes look good to me. I'll read through the promises changes now. |
|
The |
Removed Remaining additionalKeys
|
@dangoor I changed the things you remarked |
|
@WebsiteDeveloper - thanks for the fix! I'll let Kevin take it from here :-) |
|
@WebsiteDeveloper thanks for the updates, everything looks good and I'll merge it as soon as our automated build server is in the green again. |
Fixed: #1397 Code Cleanup: remove additional keys mechanism and
Fixed: #1997 Avoid use of then() on promises