This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Simplify key handlings in code hint manager. #2756
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set lastChar for "enter" and "tab" keys regardless of whether we're in a hinting session or not. This fixes issue #2691.
Remove code that dismisses code hints on pressing some keys with modifier keys. So we no longer dismiss code hints when a shortcut is pressed. We will have to fix the issue of code hints dismissal with another solution, but definitely not with key handling. This change fixes issue #2539.