Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

[cmv3] Configure autoCloseTag add-on using default settings #2759

Merged
merged 2 commits into from
Feb 1, 2013
Merged

[cmv3] Configure autoCloseTag add-on using default settings #2759

merged 2 commits into from
Feb 1, 2013

Conversation

jasonsanjose
Copy link
Member

Fixes #2541

@jasonsanjose
Copy link
Member Author

Fixes #2547 but in the cmv3 branch only.

@jasonsanjose jasonsanjose mentioned this pull request Jan 31, 2013
Closed
@ghost ghost assigned RaymondLim Feb 1, 2013
@RaymondLim
Copy link
Contributor

Looks good. It works for typing > and no more autoinsert newlines, but auto close tag is not working for typing /. It is due to the changes in CM tokenizer that indicate an unclosed tag as "error" instead of "tag". So addon/closetag.js needs to be updated for that change.

@jasonsanjose
Copy link
Member Author

Can we merge this and I'll file a separate CodeMirror bug for handling /?

@jasonsanjose
Copy link
Member Author

Filed codemirror/codemirror5#1207

@RaymondLim
Copy link
Contributor

Sure. merging now.

RaymondLim added a commit that referenced this pull request Feb 1, 2013
@RaymondLim
Merge pull request #2759 from adobe/jasonsanjose/issue-2541
b0b3153 
[cmv3] Configure autoCloseTag add-on using default settings
@RaymondLim RaymondLim merged commit b0b3153 into cmv3 Feb 1, 2013
@RaymondLim RaymondLim deleted the jasonsanjose/issue-2541 branch February 1, 2013 02:17
@jasonsanjose jasonsanjose mentioned this pull request Feb 1, 2013
Closed
@core-ai-bot core-ai-bot mentioned this pull request Aug 29, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@RaymondLim RaymondLim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonsanjose @RaymondLim