Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Add check for broken symlinks to hacking scripts (#2895) #2896

Merged
merged 1 commit into from
Feb 20, 2013
Merged

Add check for broken symlinks to hacking scripts (#2895) #2896

merged 1 commit into from
Feb 20, 2013

Conversation

jbalsas
Copy link
Contributor

@jbalsas jbalsas commented Feb 16, 2013

This is a possible fix for #2895.

It adds an additional check for broken symlinks to the current condition.

@ghost ghost assigned gruehle Feb 19, 2013
@peterflynn
Copy link
Member

Is there a Windows equivalent to this bug too, or do the .bat files work differently?

@jbalsas
Copy link
Contributor Author

jbalsas commented Feb 20, 2013

Yeah, sorry, I forgot to mention that :/ ... I currently don't have access to any windows machine, so I couldn't test it and I can't tell for sure.

From what I saw, the .bat files are checking if exist %1\dev where the .sh were doing if [ -d "${1}/Contents/dev" ]. I'm not quite sure if the condition will fail in windows for broken symlinks, or if it will just check they exist, and I haven't been able to find information about it.

It'd be great if someone could do a quick check, just to be sure.

@gruehle
Copy link
Member

gruehle commented Feb 20, 2013

Works great! The Windows version was fine as-is.

gruehle added a commit that referenced this pull request Feb 20, 2013
Add check for broken symlinks to hacking scripts (#2895)
@gruehle gruehle merged commit 52da880 into adobe:master Feb 20, 2013
@jbalsas jbalsas deleted the fix-2895 branch February 20, 2013 23:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants