This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fixed: #1863 Selector width info is wrong when no space before '{' #3082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
This looks good. Can you add some unit tests to the CSSUtils tests with rules as follows:
|
|
Done with initial review. |
|
@redmunds i added the unit tests and also fixed a few more edge cases |
| beforeEach(function () { | ||
| init(this, selectorPositionsFileEntry); | ||
| runs(function () { | ||
| selectors = CSSUtils.extractAllSelectors(this.fileCssContent); |
There was a problem hiding this comment.
Since you're using the same .css file for all tests in this section, and the file is not being edited, there's no need to run extractAllSelectors() (which is not cheap) before each test. The tests will run faster if this is done only once.
|
Done with second review. |
|
@redmunds ready for final review |
|
Looks good. Merging. |
redmunds
added a commit
that referenced
this pull request
Mar 14, 2013
Fixed: #1863 Selector width info is wrong when no space before '{'
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #1863 and also fixed a few other cases where selection was incorrect