This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
[Review only] Harden Live Development startup #3142
Merged
gruehle
merged 12 commits into
adobe:master
from
iwehrman:iwehrman/live-development-startup-refactoring
Mar 19, 2013
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
31a9ef3
Modify _openDocument to return a promise that resolves or rejects onl…
4b00554
Modify Inspector.connected() so that it returns true only if the refe…
e9fd9e0
Rename getAvailableSockets to getDebuggableWindows, which is what the…
8379fa2
Modify connectToURL so that the promise it returns is not resolved un…
5b2dc4e
Ensure that agents are loaded before attempting to load the main live…
7d08b85
Modify close() to ensure that the socket isn't closed until after clo…
314b29f
Address Randy's and NJ's review comments.
5488286
Merge branch 'master' into iwehrman/live-development-startup-refactoring
07d46d8
Address issues found by @gruehle and @WebsiteDeveloper. In particular…
f66491c
Initialize the domains exposed by Inspector synchronously.
3cf56a0
Add a unit test for `Inspector.connectToURL` and `Inspector.disconnect`
c1cb696
Add documentation of the fact that the _openDocument promise, as impl…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Modify _openDocument to return a promise that resolves or rejects onl…
…y after all the related documents have resolved or rejected. Callers are modified to wait for the promise to resolve before proceeding. This fixes a bug in which _closeDocument could be called before _openDocument had finished.
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the status be set in the fail case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe. It wasn't obvious what the behavior should be in the failure case.
_openDocument
will fail if any of the related files (i.e., stylesheets) fail to load. It's not clear that such a failure ought actually to prevent_openDocument
from succeeding.On second thought, I think instead the
fail
handler should be removed and thedone
handler should be changed to analways
handler. The thing I want to accomplish is to prevent_onLoad
from completing before_openDocument
, and not to make the function more strict.