This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Localize creative commons license URL #3624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… french translation from last lockit.
| "ABOUT_TEXT_LINE4": "La documentation et la source sont disponibles à l’adresse <a class=\"clickable-link\" data-href=\"https://github.com/adobe/brackets/\">https://github.com/adobe/brackets/</a>.", | ||
| "ABOUT_TEXT_LINE5": "Développé avec \u2764 et JavaScript par :", | ||
| "ABOUT_TEXT_LINE6": "De nombreux contributeurs (information indisponible pour le moment).", | ||
| "ABOUT_TEXT_WEB_PLATFORM_DOCS": "Web Platform Docs et le logo graphique Web Platform sont mis à disposition sous licence Creative Commons Attribution, <a class=\"clickable-link\" data-href=\"http://creativecommons.org/licenses/by/3.0/\">CC-BY 3.0 Unported.", |
There was a problem hiding this comment.
@ybayer The last lockit somehow dropped the end tag </a>. I also changed "unported" to "non transposé" per the content of the license.
Conflicts: src/nls/fr/strings.js
ghost
assigned 
| /*global define */ | ||
|
|
||
| define({ | ||
| // Relative to the samples folder |
There was a problem hiding this comment.
I'm sure you know that there's no "GETTING_STARTED" for ja. Should there be a placeholder?
There was a problem hiding this comment.
No placeholder. We let the i18n plugin find and use the root URL.
|
Done with initial review. |
|
Waiting to hear back from @julianasuh, @adrocknaphobia or @ryanstewart about the Japanese license. |
|
@jasonsanjose Sounds like we are not concerned about ja version for now, correct? Is this ready to merge? |
Conflicts: src/strings.js
|
Ready to merge now. Had to fix a merge conflict. |
|
Merging. |
redmunds
added a commit
that referenced
this pull request
May 13, 2013
Localize creative commons license URL
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll contact @ybayer about the translation impact.
Do not merge for Sprint 24. Will re-evaluate post-MAX.