This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Handle regexp replacements with $1, $2, etc. properly #5618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging. I also added a simple unit test for the single-replace case. (We should have unit tests for Replace All too, but I didn't see any existing ones--in general we need to beef up the unit tests in this area when we do the "official" Find/Replace epic.) Thanks @SAplayer - let me know if you see anything amiss with my final changes. |
njx
added a commit
that referenced
this pull request
Oct 22, 2013
Handle regexp replacements with $1, $2, etc. properly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #5275. Supersedes #5295.