This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Disallow tabbing to prev and next buttons #5848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
This is definitely a safe fix. Until we can handle tabbing in toolbar, preventing users to tab to those buttons are a reasonable fix. |
RaymondLim
added a commit
that referenced
this pull request
Nov 6, 2013
Disallow tabbing to prev and next buttons
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #5766.
This restores Find dialog behavior to what it was before prev and next buttons were added so that tabbing dismisses dialog.
I also tried to add no-focus class to the Find dialog to disallow click to steal focus from the text field, but it doesn't seem to work.
We're eventually going to rewrite Find, Replace, and Find in Files dialogs, so I think this is sufficient for this bug.