-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Conversation
@sathyamoorthi Would you mind resolving the merge issue? I'd like to get this PR into master. Thank you. |
@ingorichter Shall i include other changes that this #5497 contains. They merged new |
Conflicts: src/document/DocumentCommandHandlers.js
@ingorichter I think, i should have fixed your merge issues. Please take a look. |
@sathyamoorthi wow, I think this looks like a lot of changes. I would recommend to check out a clean copy of the repo and apply your changes there and submit a new PR. I don't know how to fix the current PR to only contain the changes that you've made. Sorry for telling you that. |
This PR looks clean to me--only 3 line diffs and 4 commits (of which two were merge commits). Maybe GitHub got briefly confused? |
Ok let me give new PR. But, shall i include my other changes in this PR (close other improvements) to my new PR? |
@ingorichter I created two new pull requests. #5951 - only few lines of changes to fix issue 5800. #5952 - it has fix for issue 5800 along with some improvements. They were discussed already in this PR #5497. But please pull any one of this before sprint 34. If you pull 5951, let 5952 open and assign it to @JeffryBooher. And i really don't know why my 'upstream/master' merge commits are stick along with these pull requests. I only ran these two commands based on this document.
If you still feel anything weird, please do let me know. I can delete my entire fork and create new fork for this PR. |
@njx weird. The page to show all the diffs was hardly rendered. |
@JeffryBooher Fix for issue #5800 introduced by #4590