Switch language / syntax mode of current document #6409

peterflynn · 2014-01-08T09:32:20Z

This is an update of @JakeStoeffler's PR #4276. It's merged up with the latest master and addresses the main code review comments I made there. I also added some simple unit tests.

I still have two concerns about merging this immediately, though:

1) The dropdown UI doesn't look great. It uses a native <select>, which is just hard to style... and the way the statusbar is laid out makes it look misaligned in this case:

It would look nicer if we used an HTML popup like code hints, context menus, and the Recent Projects dropdown... but it would definitely add a bunch more work here. So maybe we can skate by with the current <select>-based UI for now. @larz0, any thoughts?

2) This foregrounds all the bugs in #2911 a lot more. I added a checklist of issues there. Are there any that are prominent enough to act as blockers here? (JS code hints seems like it might be the most glaring issue, but unfortunately that's one of the harder ones to fix too).

…rackets into pflynn/JakeStoeffler-languageselector-updated # By Jake Stoeffler # Via Jake Stoeffler * 'languageselector' of https://github.com/JakeStoeffler/brackets: Setting default language resets force flag Move forced flag to Document Replace modal dialog with custom <select> Fix API changes to not publicly expose things we shouldn't ;) Pass Strings by reference (per #4252) Add reset button; add file name to dialog title Initial commit of language select dialog Conflicts: src/extensions/default/JSLint/thirdparty/jslint

- Disable language switching for untitled documents - Remove unneeded imports - Switch from deprecated CollectionUtils to lodash - Fix label truncation bug - Fix bug where language change is made redundantly multiple times - Rename some methods for clarity - Add two simple unit tests

…e list

TomMalbran · 2014-01-08T17:02:25Z

The algiment issue is caused by the padding around the actual select. The select doesn't have any border, but it still starts where the "LESS" text is. We could fix it by removing the padding around the select and placing it into the select.

lkcampbell · 2014-01-31T03:17:34Z

@peterflynn, @jasonsanjose, if you guys are in the process of figuring out the Sprint 37 pull requests to merge, this one gets my vote. This functionality would be very useful, especially if the document specific preference keep track of the language assigned to the document.

njx · 2014-02-04T00:50:18Z

I added this to Nominations on the Kanban board.

busykai · 2014-02-27T18:51:17Z

@peterflynn, do you have time to merge the current master to this PR? I'll see how bad the issues from your checklist in #2911 look like... The first three seem to be quite important to address.

…ler-languageselector-updated Conflicts: src/editor/EditorStatusBar.js src/widgets/StatusBar.html

busykai · 2014-02-28T19:06:33Z

@peterflynn, merged master into your branch locally. let me know if you want me to push it to your branch.

bad alignment can be solved by adding left padding and the same amount of negative margin to the select. i have this fix in my local branch as well.

peterflynn · 2014-02-28T19:10:55Z

Sounds good -- thanks!

TomMalbran · 2014-02-28T22:44:50Z

Instead of using a select can we use something similar to the button dropdown used in the File Filters and CSS Quick Edit, once the File filters are merged?

peterflynn · 2014-02-28T23:02:12Z

@TomMalbran That's a great idea! Would probably make it easier to indicate the 'current' value too (e.g. placing a bullet or checkmark next to it as in menu-based picker UIs).

TomMalbran · 2014-02-28T23:05:44Z

The design is nicer too and won't have the same problems as the select has now. The checkmarks will look good too. We just need to wait until the Find Filters are merged to be able to use it.

busykai · 2014-03-01T12:25:02Z

@TomMalbran great idea indeed! The native select looks out of the place, but I was struggling to find existing replacement. I'll fetch it once it lands.

busykai · 2014-03-07T00:56:39Z

OK, so #7015 has landed, I can take the widget from there now...

peterflynn · 2014-03-07T01:20:41Z

Cool, yay!

peterflynn · 2014-06-19T09:20:05Z

@busykai Awfully sorry for the delay. Thanks for all the fixes! And the unit test additions look great too.

So there's really just that one seeming bug in JavaScriptCodeHints/main.js, and then the two smaller questions/issues (whether to make Document.setLanguageOverride() private & understanding why the bit in setCurrentDocument() was moved in that last commit).

If we wanted to get this in for Sprint 0.41, we should try to land it by Friday. Do you have cycles this week to finish it off? If not lmk -- I can probably push up those last cleanups and then get someone else to review that incremental diff quickly.

peterflynn · 2014-06-19T09:28:06Z

Oh, and we need to merge up with master too

busykai · 2014-06-19T17:37:30Z

@peterflynn I will have some today and tomorrow morning. Let's see if I can make it. I'll let you know once I run out of cycles.

…ler-languageselector-updated Conflicts: src/styles/brackets_patterns_override.less

busykai · 2014-06-20T16:19:54Z

@peterflynn, ready. Didn't look into making Document.setLanguageOverride() private. Please feel free to make any changes necessary -- I won't be able to get back to this today.

peterflynn · 2014-07-10T22:22:07Z

src/extensions/default/JavaScriptCodeHints/main.js

@@ -623,6 +621,18 @@ define(function (require, exports, module) {
         * @param {Editor} previous - the previous editor context
         */
        function handleActiveEditorChange(event, current, previous) {
+            // Uninstall "languageChanged" event listeners on the previous editor's document
+            if (previous && previous !== current) {


Out of curiosity, were you seeing cases where the event was sent with previous === current? That shouldn't ever happen... (I don't think it blocks landing this, but if there's a bug in EditorManager it'd be good to know about it!)

I've verified this is impossible, and removed that check in cc47043

@njx

…r-languageselector-updated * origin/master: (66 commits) updating 'Last translated' SHA to reflect last pull request Use XML highlighting for .xaml files Wordsmithing (@njx) Update Getting Started (How to change the project, why?) Update CM to the latest Easier notation Revert change to non-translation file Change Copyright year in strings.js Updated by ALF automation. Update Sha German translation (Sprint 41) modalbar already showing, adjust for old height Fixes after Review Tweak the Command constant for the new command which doesn't appear on the file menu. alf updates for release branch Changes after review. Small fixes Spanish translations for Release 0.41 Updated by ALF automation. isolated fix for changing height of modal bar with filter picker ...

- Fix bug in DropdownButton that led to it often being positioned too far to the left - CSS to join more cleanly with top border of status bar (not perfect, though: the dropshadow & animation both still feel a little odd)

peterflynn · 2014-07-10T23:20:26Z

I've pushed up a quick tweak to improve how the dropdown/popup gets positioned. Whew! I think this is finally ready to roll now. @busykai Thanks so much for all your patience with my dilly-dallying on this :-( And @JakeStoeffler Thanks for originally getting the ball rolling all those months ago!

…ctor-updated Switch language / syntax mode of current document

peterflynn · 2014-07-11T00:03:42Z

@larz0 I don't think it's critical, but if you have time in the next week or so would you mind taking a look at the language switcher popup's appearance? The default dropshadow looks a little awkward here because it makes the popup feel separated from the status bar button below it (normally, this popup drops downward as seen in the Find in Files bar... but not here). Similarly, the dropdown opening animation seems calibrated for when it drops down instead of upward. Can you think of any easy tweaks that would improve that stuff?

larz0 · 2014-07-11T00:36:01Z

@peterflynn np I can take a look.

codenamezjames · 2015-12-16T17:43:18Z

Hey what is the status on this i was just thinking about making a extension to auto save the untitled doc to my temp folder so i could use highlighting. If this is coming soon i wont waste my time. Thanks for all the awesome work you guys are doing!

sprintr · 2015-12-16T19:19:23Z

This has been merged a while ago. Secondly it doesn't deal with untitled files.

JakeStoeffler and others added 10 commits June 18, 2013 23:07

Initial commit of language select dialog

6c34d70

Add reset button; add file name to dialog title

6e8f881

Pass Strings by reference (per #4252)

c047b0b

Fix API changes to not publicly expose things we shouldn't ;)

d37f69b

Replace modal dialog with custom <select>

3d6e752

Move forced flag to Document

50ad04c

Setting default language resets force flag

6e07bdb

Language switcher: filter out binary languages (image, audio) from th…

f8a2b96

…e list

This was referenced Jan 8, 2014

Switch language / syntax mode of current document #4276

Closed

Language changes due to renames are not sufficiently recognized #2911

Open

ghost assigned jasonsanjose Jan 8, 2014

peterflynn mentioned this pull request Jan 16, 2014

Console error whenever new file is created in project where defaultExtension is set #6539

Closed

redmunds mentioned this pull request Feb 5, 2014

adds getLanguages() for accessing the language map #6768

Closed

Merge remote-tracking branch 'upstream/master' into pflynn/JakeStoeff…

7dca978

…ler-languageselector-updated Conflicts: src/editor/EditorStatusBar.js src/widgets/StatusBar.html

busykai added 2 commits February 28, 2014 16:13

Fix select alignment problem.

0801076

Make linting react to document language changes.

29c9caa

Merge remote-tracking branch 'upstream/master' into pflynn/JakeStoeff…

3df7680

…ler-languageselector-updated Conflicts: src/styles/brackets_patterns_override.less

redmunds mentioned this pull request Jun 19, 2014

[Cycle times] Improving throughput calculation (based on Github label change) #8088

Closed

busykai added 2 commits June 19, 2014 17:09

Handler inline editor's language changed correctly.

5701d5c

Fix editor change when the last editor is closed.

6f4db4b

JeffryBooher removed this from the Release 0.41 milestone Jun 20, 2014

dangoor added PR Triage Complete labels Jun 23, 2014

peterflynn reviewed Jul 10, 2014
View reviewed changes

peterflynn added 2 commits July 10, 2014 15:43

Tweaks to status bar language-picker's appearance:

c118a97

- Fix bug in DropdownButton that led to it often being positioned too far to the left - CSS to join more cleanly with top border of status bar (not perfect, though: the dropshadow & animation both still feel a little odd)

peterflynn added a commit that referenced this pull request Jul 10, 2014

Merge pull request #6409 from adobe/pflynn/JakeStoeffler-languagesele…

b409212

…ctor-updated Switch language / syntax mode of current document

peterflynn merged commit b409212 into master Jul 10, 2014

peterflynn deleted the pflynn/JakeStoeffler-languageselector-updated branch July 10, 2014 23:26

peterflynn added Bug Fxing / DOD and removed Review labels Jul 11, 2014

peterflynn mentioned this pull request Aug 14, 2014

Language switcher: connect to prefs & clean up some code #8444

Merged

This was referenced Aug 30, 2021

[CLOSED] Switch language / syntax mode of current document brackets-archive/bracketsIssues#5829

Open

[CLOSED] adds getLanguages() for accessing the language map brackets-archive/bracketsIssues#6142

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch language / syntax mode of current document #6409

Switch language / syntax mode of current document #6409

peterflynn commented Jan 8, 2014

TomMalbran commented Jan 8, 2014

lkcampbell commented Jan 31, 2014

njx commented Feb 4, 2014

busykai commented Feb 27, 2014

busykai commented Feb 28, 2014

peterflynn commented Feb 28, 2014

TomMalbran commented Feb 28, 2014

peterflynn commented Feb 28, 2014

TomMalbran commented Feb 28, 2014

busykai commented Mar 1, 2014

busykai commented Mar 7, 2014

peterflynn commented Mar 7, 2014

peterflynn commented Jun 19, 2014

peterflynn commented Jun 19, 2014

busykai commented Jun 19, 2014

busykai commented Jun 20, 2014

peterflynn Jul 10, 2014

peterflynn Jul 17, 2014

peterflynn commented Jul 10, 2014

peterflynn commented Jul 11, 2014

larz0 commented Jul 11, 2014

codenamezjames commented Dec 16, 2015

sprintr commented Dec 16, 2015

Switch language / syntax mode of current document #6409

Switch language / syntax mode of current document #6409

Conversation

peterflynn commented Jan 8, 2014

TomMalbran commented Jan 8, 2014

lkcampbell commented Jan 31, 2014

njx commented Feb 4, 2014

busykai commented Feb 27, 2014

busykai commented Feb 28, 2014

peterflynn commented Feb 28, 2014

TomMalbran commented Feb 28, 2014

peterflynn commented Feb 28, 2014

TomMalbran commented Feb 28, 2014

busykai commented Mar 1, 2014

busykai commented Mar 7, 2014

peterflynn commented Mar 7, 2014

peterflynn commented Jun 19, 2014

peterflynn commented Jun 19, 2014

busykai commented Jun 19, 2014

busykai commented Jun 20, 2014

peterflynn Jul 10, 2014

Choose a reason for hiding this comment

peterflynn Jul 17, 2014

Choose a reason for hiding this comment

peterflynn commented Jul 10, 2014

peterflynn commented Jul 11, 2014

larz0 commented Jul 11, 2014

codenamezjames commented Dec 16, 2015

sprintr commented Dec 16, 2015