This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Changed CodeInspector.inspectFile to accept provider.scanFile functions that return the result via a promise #6606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change would in particular allow the less-autocompile extension to perform proper error reporting. |
|
Sorry for not checking the issues for a similar item. I will leave the pull request open for reference. Feel free to close it when it becomes redundant. |
ghost
assigned 
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables third party extensions to use the CodeInspector APIs to report errors from external compilers that are triggered via node and thus must be run asynchronously. The change retains backwards compatibility.