This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
[JSLint] Respects tabSize setting when useTabChar is true #7243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function _getIndentSize() { | ||
| return PreferencesManager.get("useTabChar") ? PreferencesManager.get("tabSize") : PreferencesManager.get("spaceUnits"); | ||
| } | ||
|
|
There was a problem hiding this comment.
I already fixed this in PR #7186, but the file path should be passed to PreferencesManager.get():
function _getIndentSize(fullPath) {
return PreferencesManager.get(
PreferencesManager.get("useTabChar", fullPath) ? "tabSize" : "spaceUnits",
fullPath
);
}
Then pass "fullPath" to this function below.
There was a problem hiding this comment.
Ok, I can update once #7186 gets merged or you can close this and include it there.
There was a problem hiding this comment.
No problem. Proceed with this fix and we can merge changes when necessary.
|
Looks good. Merging. |
redmunds
added a commit
that referenced
this pull request
Mar 21, 2014
[JSLint] Respects tabSize setting when useTabChar is true
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue here: #7240
Similar approach is taken here:
https://github.com/adobe/brackets/blob/master/src/editor/EditorStatusBar.js#L74-76