Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Moved .notification icon in Extension Manager dialog #7287

Merged
merged 1 commit into from
Mar 25, 2014
Merged

Moved .notification icon in Extension Manager dialog #7287

merged 1 commit into from
Mar 25, 2014

Conversation

logarytm
Copy link
Contributor

I've rearranged the .notification item (installed extensions number) badge so that clicking it switches to the Installed Extensions tab. Appropriate .less files also got modified in order to get the icon themed properly. This aims to fix bug #7280.

…ixes #7280)

I've also updated styles/brackets_pattern_override.less so that it is covered by the style sheet.
@peterflynn
Copy link
Member

@winek You have to sign the Contributor License Agreement before we can merge your first contribution (this is par for the course in most open source projects).

@logarytm
Copy link
Contributor Author

Signed, is there any way to rerun the build?

@redmunds
Copy link
Contributor

To rerun the build, click on the "Details" link next to "Failed — The Travis CI build failed" to go to the Travis page, then click the button in upper right that looks like a refresh button (tooltip says "Restart Build").

@logarytm
Copy link
Contributor Author

There is no "Restart Build" button. Perhaps because I don't have write access to the adobe/brackets repository?

@redmunds
Copy link
Contributor

I just restarted the build. For future reference, make sure you're logged in.

@marcelgerber
Copy link
Contributor

@redmunds The button is only shown if you have write access to the repo - so only commiters can do that.

@redmunds
Copy link
Contributor

@SAplayer OK. Seems like the person who submitted the pull request should also be able do that.

@marcelgerber
Copy link
Contributor

Nope, you need to be collaborator of adobe/brackets.

@pthiess
Copy link
Contributor

pthiess commented Mar 24, 2014

@lkcampbell Could you please take look - Thanks :)

@lkcampbell
Copy link
Contributor

Looks good. Merging.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants