Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Changed project settings dialog from OK to Done #7508

Merged
merged 1 commit into from
Jun 3, 2014
Merged

Changed project settings dialog from OK to Done #7508

merged 1 commit into from
Jun 3, 2014

Conversation

lallmon
Copy link
Contributor

@lallmon lallmon commented Apr 14, 2014

This would fix #7084

@larz0
Copy link
Member

larz0 commented Apr 14, 2014

Thanks @Lucaska, looks good. Someone else will review this soon.

@lallmon
Copy link
Contributor Author

lallmon commented Apr 14, 2014

Awesome. I know it's not a huge fix but my first PR outside of my own Repos 👀

@njx
Copy link
Contributor

njx commented Apr 24, 2014

@Lucaska - thanks for working on this.

@larz0 In the original bug I think we wanted to do a sweep of all the dialogs and figure out if there were any others that needed the same change. Have you already done that?

Marking low priority.

@larz0
Copy link
Member

larz0 commented Apr 29, 2014

@njx I've done a sweep and Project Settings dialog is the only one.

@marcelgerber marcelgerber mentioned this pull request Apr 30, 2014
8 tasks
@larz0
Copy link
Member

larz0 commented May 28, 2014

@njx not sure if this is still on your radar. It's pretty small.

@njx
Copy link
Contributor

njx commented Jun 3, 2014

Merging. Sorry for the delay @Lucaska.

njx added a commit that referenced this pull request Jun 3, 2014
Changed project settings dialog from OK to Done
@njx njx merged commit 49d489f into adobe:master Jun 3, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace "OK" with "Done" for Project Settings Dialog
3 participants