Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Fix StepsEditor labeling position bug on fontsizechange #7742

Merged
merged 2 commits into from
May 4, 2014

Conversation

marcelgerber
Copy link
Contributor

This fixes #6808 @redmunds @larz0

@redmunds redmunds self-assigned this May 3, 2014
@TomMalbran
Copy link
Contributor

Should the labels actually change their size? It looks to me that only the code size is changed and everything else stays the same, so maybe we should just change the labels font-size to use px so that those don't change in size.

@marcelgerber
Copy link
Contributor Author

The font-size is explicitely set to 75%, that's all I can say. @redmunds

@TomMalbran
Copy link
Contributor

Yes, that is the real issue here. If it was set in px, we wouldn't have any issue when changing the font size.

@redmunds
Copy link
Contributor

redmunds commented May 4, 2014

@SAplayer The problem is that it's 75% of Editor font size, but it should be proportional to the rest of the UI so it doesn't zoom with editor.

Take a look at the text in the header of the CSSInlineEditor (file name and New Rule button) and notice how it doesn't zoom when editor is zoomed. The font size there is simply set in px as @TomMalbran suggests.

@marcelgerber
Copy link
Contributor Author

@redmunds So should we change it?

@redmunds
Copy link
Contributor

redmunds commented May 4, 2014

Yes, it should be changed from % to px for both step and bezier curve editors.

9px matches what we have now, but we could go 10px or 11px. With this change it's not necessary to change padding, top, or left.

@marcelgerber
Copy link
Contributor Author

Changed.

@redmunds
Copy link
Contributor

redmunds commented May 4, 2014

Looks good. Merging.

redmunds added a commit that referenced this pull request May 4, 2014
Fix StepsEditor labeling position bug on fontsizechange
@redmunds redmunds merged commit b756e4f into adobe:master May 4, 2014
@marcelgerber marcelgerber deleted the step-editor-fontchange branch May 4, 2014 16:51
left: 0;
width: 100%;
padding: .3em .5em;
padding: .3em .5em 0 .3em
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed the semicolons here, so I fixed it in 6dc1b4a

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[StepsEditor] Wrong labeling positioning after changing font size
3 participants