This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Adding comment to prevent issue #735 #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…font to increase font size
ghost
assigned
redmunds
added a commit
that referenced
this pull request
May 9, 2012
Adding comment to prevent issue #735
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #735 (line number stop short) occurred for Adam because he edited the code font size and line-height for presentation purposes. Line height was changed from px to em. Since the code font and line number font sizes are different in codemirror, line-height must be absolute rather than relative to the font in order for the line numbers and code lines to line up.
This fix just adds a comment about keeping line-height specified in px to help out anyone who may manually edit the font size and line-height size
fixes issue #735