Project panel bug fixes #845

jasonsanjose · 2012-05-09T00:43:26Z

Editor top shadow is sized incorrectly #830 refine jQuery selection to only modify shadows within the sidebar
Editor shadow is drawn over menu #838 fix z-order of toolbar to appear over editor shadow
Tree scroll position jumps back to selection upon expand/collapse #800 suppress reveal of jstree selection when expanding/collapsing unrelated folders
Selection is not restored in project tree after closing and opening parent folder #741 restore current document selection when expanding it's ancestor folder

FYI @ryanstewart - Opportunistic refactor of sidebar resize handling to clean up dependencies in ProjectManager.js and brackers.js. Sets the stage for a future ProjectManager UI separation.

…z-index of toolbar.

…for jstree expand/collapse and all content changes.

Add option to suppress revealing of jstree selection.

gruehle · 2012-05-09T19:56:46Z

Reviewing

gruehle · 2012-05-09T19:59:09Z

src/command/Commands.js

@@ -66,7 +66,7 @@ define(function (require, exports, module) {
    // Navigate
    exports.NAVIGATE_QUICK_OPEN     = "navigate.quickOpen";
    exports.NAVIGATE_GOTO_DEFINITION = "navigate.gotoDefinition";
-    exports.NAVIGATE_GOTO_LINE  	= "navigate.gotoLine";
+    exports.NAVIGATE_GOTO_LINE      = "navigate.gotoLine";


Since you're fixing one, you might as well fix them all :-)

gruehle · 2012-05-09T21:45:01Z

I found a bug in the new implementation:

Open brackets/src folder (if not already open), and make sure all top-level folders are closed
Open the editor folder
Select Editor.js
Close the editor folder (the editor folder itself should now be highlighted)
Open the document folder

Results:
DocumentCommandHandlers.js is highlighted, but not selected.

gruehle · 2012-05-09T21:47:26Z

src/project/SidebarView.js

@@ -0,0 +1,167 @@
+/*


Thanks for factoring this into a new file! :-)

Woohoo. And someday a refactored ProjectManager will fit in here too.

gruehle · 2012-05-09T22:06:30Z

Done with initial review. Looks like you need to do another merge with master.

Conflicts: src/brackets.js src/utils/ViewUtils.js src/view/ViewCommandHandlers.js

jasonsanjose · 2012-05-10T00:07:04Z

Fixed the bug Glenn found. Merged with master.

ryanstewart · 2012-05-10T00:11:11Z

Sweet, thanks for cleaning all this up @jason-sanjose. Looking forward to seeing it land.

gruehle · 2012-05-10T00:44:40Z

Found another bug:

Double click to close the sidebar
Move the cursor near the left edge of the window until it turns into a resize cursor
Try to drag the sidebar open. Problem 1: can't
Realize that didn't work, so you try double-clicking. Problem 2: doesn't reopen
Realize that didn't work, so you select "Show Sidebar". Problem 3: doesn't reopen
Figuring "aw, what the heck", you try selecting "Show Sidebar" again. IT WORKS! :-)

gruehle · 2012-05-10T01:41:51Z

I just noticed another issue too: the editor shadow is not adjusted when the window is resized. Open a file, scroll a bit so you get the shadow and make the window wider. The shadow doesn't get wider.

jasonsanjose · 2012-05-10T03:26:27Z

Fixed the Glenn's latest issues.

gruehle · 2012-05-10T14:33:45Z

Thanks, Jason. Everything is looking great, but there is one last minor issue: when the sidebar is collapsed, if you drag it slowly to open it, it always snaps shut. If you drag it really fast you can get it to open. It looks like this is due to the mousemove logic that snaps the sidebar closed when e.clientX < 10.

…d to open.

gruehle · 2012-05-10T17:52:06Z

Looks great! Merging.

Project panel bug fixes

jasonsanjose added 3 commits May 8, 2012 16:12

Refactor sidebar resize to SidebarView. Fix editor shadow width. Fix …

8c3f0ff

…z-index of toolbar.

Revert initial refactor of ProjectView. Do not fire selectionChanged …

2b7678b

…for jstree expand/collapse and all content changes.

Restore selection on a file when reopening an ancestor folder.

6206c7c

Add option to suppress revealing of jstree selection.

jasonsanjose mentioned this pull request May 9, 2012

Added support for double clicking the project panel to close it #825

Closed

Add dblclick to toggle. Fix triangle visibility when snapping.

1293674

ghost assigned gruehle May 9, 2012

gruehle reviewed May 9, 2012
View reviewed changes

jasonsanjose added 3 commits May 9, 2012 16:57

Code review comments. Fixes selection marker when closing jstree nodes

7d9e1d5

Merge branch 'refs/heads/master' into jason-sanjose/issue800

bddd5cf

Conflicts: src/brackets.js src/utils/ViewUtils.js src/view/ViewCommandHandlers.js

Use updated hyphenated names

50ba90d

jasonsanjose added 3 commits May 9, 2012 19:23

Increase sidebar resizer width. Fix dblclick bugs.

56f8035

Fix scroller shadow resize

e1f6122

Don't resize shadow when using absolute positioning.

5c4f962

fix merge issues

41fc773

Cleanup sidebar resizer. Fix edge case when moving from snapped close…

a0b2f6d

…d to open.

jasonsanjose added 2 commits May 10, 2012 10:21

Merge branch 'refs/heads/master' into jason-sanjose/issue800

7dec20d

fix comment for _setWidth

2920abe

gruehle added a commit that referenced this pull request May 10, 2012

Merge pull request #845 from adobe/jason-sanjose/issue800

ed38cf1

Project panel bug fixes

gruehle merged commit ed38cf1 into master May 10, 2012

core-ai-bot mentioned this pull request Aug 29, 2021

[CLOSED] Project panel bug fixes brackets-archive/bracketsIssues#840

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Project panel bug fixes #845

Project panel bug fixes #845

jasonsanjose commented May 9, 2012

gruehle commented May 9, 2012

gruehle May 9, 2012

jasonsanjose May 9, 2012

gruehle commented May 9, 2012

gruehle May 9, 2012

jasonsanjose May 10, 2012

gruehle commented May 9, 2012

jasonsanjose commented May 10, 2012

ryanstewart commented May 10, 2012

gruehle commented May 10, 2012

gruehle commented May 10, 2012

jasonsanjose commented May 10, 2012

gruehle commented May 10, 2012

gruehle commented May 10, 2012

Project panel bug fixes #845

Project panel bug fixes #845

Conversation

jasonsanjose commented May 9, 2012

gruehle commented May 9, 2012

gruehle May 9, 2012

Choose a reason for hiding this comment

jasonsanjose May 9, 2012

Choose a reason for hiding this comment

gruehle commented May 9, 2012

gruehle May 9, 2012

Choose a reason for hiding this comment

jasonsanjose May 10, 2012

Choose a reason for hiding this comment

gruehle commented May 9, 2012

jasonsanjose commented May 10, 2012

ryanstewart commented May 10, 2012

gruehle commented May 10, 2012

gruehle commented May 10, 2012

jasonsanjose commented May 10, 2012

gruehle commented May 10, 2012

gruehle commented May 10, 2012