Implement Splitview #8913
Implement Splitview #8913
Conversation
…sLint in Brackets
|
Curiosity, what is the current time frame for Splitview to land in master? I know my extension breaks as part of the ImageViewer refactoring, and I am trying to work out a time frame for making it compatible. |
|
@le717 We're merging it this week. |
|
@JeffryBooher Thank you! |
|
Alright, let's get this puppy onto master... |
Implement Splitview (with non-final UI)
|
I'll leave it to @larz0 or @ryanstewart to add the appropriate animated GIF now :-) |
| @@ -155,6 +155,10 @@ define(function HTMLDocumentModule(require, exports, module) { | |||
| self._onChange(event, editor, change); | |||
| }); | |||
|
|
|||
| $(this.editor).on("beforeDestroy.HTMLDocument", function (event, editor) { | |||
| self._onDestroy(event, editor); | |||
| }); | |||
There was a problem hiding this comment.
@JeffryBooher How come this is necessary for HTMLDocument, but not CSSDocument or CSSPreprocessorDocument? All three of them have a detachFromEditor() that needs to get run...
I'm also not clear on why this change is needed, though. It already listens to "activeEditorChange", which should be enough to always clean up when needed. Was this added for a unit test or something maybe, where the EditorManager events weren't firing?
|
|
|
|
|
|
Known Issue:
#8513 (comment)
The selection is getting reworked with @larz0 UI treatment and will be addressed at that time
This is a rebased branch and replaces #8522 for merging into master