Pipes: fix block extraction of module-qualified macros. Closes #91

CHANGELOG.md

@@ -9,6 +9,7 @@
 ### Fixes
 
 * charlists: rewrite empty charlist to use sigil (`''` => `~c""`)
+* pipes: don't blow up extracting fully-qualified macros (`Foo.bar do end |> foo()`, #91, h/t @NikitaNaumenko)
 
 ## v0.10.2
 

lib/style/pipes.ex

@@ -103,7 +103,14 @@ defmodule Styler.Style.Pipes do
       #
       # block_result
       # |> ...
-      variable = {:"#{fun}_result", [line: line], nil}
+      var_name =
+        case fun do
+          fun when is_atom(fun) -> fun
+          {:., _, [{:__aliases__, _, _}, fun]} when is_atom(fun) -> fun
+          _ -> "block"
+        end
+
+      variable = {:"#{var_name}_result", [line: line], nil}
       new_assignment = {:=, [line: line], [variable, lhs]}
       {variable, new_assignment}
     else

test/style/pipes_test.exs

@@ -125,6 +125,31 @@ defmodule Styler.Style.PipesTest do
       )
     end
 
+    test "block extraction: names aliased modules" do
+      assert_style(
+        """
+        Foo.bar do
+          :ok
+        end
+        |> case do
+          :ok -> :ok
+          _ -> :error
+        end
+        """,
+        """
+        bar_result =
+          Foo.bar do
+            :ok
+          end
+
+        case tx_result do
+          :ok -> :ok
+          _ -> :error
+        end
+        """
+      )
+    end
+
     test "macro with arg and do block" do
       assert_style("""
       "baz"