Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dutch translations not working #426

Closed
tombrouwer opened this issue May 19, 2022 · 1 comment
Closed

Dutch translations not working #426

tombrouwer opened this issue May 19, 2022 · 1 comment
Assignees
Labels

Comments

@tombrouwer
Copy link
Contributor

Hi @trieloff,

Thank you for merging the Dutch translations. I think I did something wrong. When I choose nl-NL it tells me I can only use en_US and de. I looked at the code where I can add nl-NL but I didn't find it can you add it or tell me where to add. And maybe it is a better idea to call the Dutch translation file also with a underscore like the English one? eg: nl_NL

Expected Behaviour

Using Dutch translations

Actual Behaviour

Argument: l, Given: "nl-NL", Choices: "en_US", "de"

Reproduce Scenario (including but not limited to)

/jsonschema2md -l nl-NL -d ./schemas -o ./docs -x -

Steps to Reproduce

Create a schema and run the command with -l nl-NL

Platform and Version

All (I think)

Sample Code that illustrates the problem

Argument: l, Given: "nl-NL", Choices: "en_US", "de"

trieloff pushed a commit that referenced this issue May 19, 2022
## [7.1.1](v7.1.0...v7.1.1) (2022-05-19)

### Bug Fixes

* **i18n:** align Dutch locale name with standard pattern ([d940cd4](d940cd4)), closes [#426](#426)
* **i18n:** dutch locale available as command line option ([e8c9304](e8c9304)), closes [#426](#426)
* **i18n:** support Dutch locale as command line option ([0c0fbbd](0c0fbbd))
@trieloff
Copy link
Collaborator

🎉 This issue has been resolved in version 7.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants