Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:I18n fix #158

Merged
merged 2 commits into from
Jul 31, 2019
Merged

fix:I18n fix #158

merged 2 commits into from
Jul 31, 2019

Conversation

Claymore1337
Copy link
Contributor

@Claymore1337 Claymore1337 commented Jul 31, 2019 •
edited
Loading

fix #157

Add path for loading the translation file.

Moved the init for i18n form markdownWriter and readmeWriter to cli.js

COMLINE\Kunz added 2 commits July 30, 2019 14:06
fix(markdownwriter.js): use path function to resolve the path
5fe7db2 
the i18n path was build by strings. now it use path to resolve it

fix adobe#157
fix(i18n init): moved the i18n init part to the cli.js
5e37d2d 
there was an bug in the init part of the i18n setup. It was moved to the cli to handle it in the
same way

fix adobe#157
@trieloff trieloff merged commit 5a916a8 into adobe:master Jul 31, 2019
@trieloff
Copy link
Collaborator

🎉 This PR is included in version 3.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trieloff trieloff trieloff approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

i18n breaks usage outside of jsonschema2md repo
2 participants
@Claymore1337 @trieloff