-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 rewrite #181
V2 rewrite #181
Conversation
BREAKING CHANGE: Repaces lodash with ferrum, removed bluebird, changes the meaning of `--schema-out` or `-x` to be no longer relative to output dir The `--schema-out` or `-x` command line option is no longer relative to the output path (specified with `-o` or `--out`)
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What's meant by "schemas are no longer validated"? |
We used to have a dependency to
for very little benefit. In order to implement #100 and generate the list of supported and unsupported keywords (https://github.com/adobe/jsonschema2md/blob/master/schemasupport.md) I've tagged every use of a keyword in the code with |
I hadn't realised you had made the jump to draft 2019-09! Very exciting! |
This is still a work in progress of what will become an effective re-write of
jsonschema2md
Some of the changes that are coming:
optimist
(unmaintained) replaced withyargs
bluebird
,lodash
replaced withferrum
i18n
(with unmaintained dependencies) replaced withes2015-i18n-tag
ejs
templates withmast-builder
(Switch from EJS templates to Unist-Builder? #126 and broken ejs results in empty source file #174)anyOf
,oneOf
,allOf
, andnot
(Unknown type for array with anyOf items #94 and The generator does not handle allOf/anyOf/oneOf properly if schemas include properties, and are not references. #52 and Support not keyword #20)Some things will be made easier with the change:
And some things will be made impossible:
but this is still work in progress and a couple of things remain to be done:
jasmine
withmocha
and measure code coverageadditionalProperties
additionalProperties currently only works as a boolean. #95additionalItems
HandleadditionalItems
and arrays that specify schema order. #31patternProperties
Nested Pattern Properties ignored #180en
is default locale)