-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FocusScope missing parent element #3908
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really happy we found the root cause
Build successful! 🎉 |
Build successful! 🎉 |
## API Changes
unknown top level export { type: 'identifier', name: 'Column' } |
Closes #3877
We're still trying to figure out what circumstances can lead to this, discussion in the issue. However, it's a safe enough guard. The first thing that focusFirstInScope will call is getScopeRoot, which may return null/undefined. Rather than blow up the application, we can just do nothing.
✅ Pull Request Checklist:
📝 Test Instructions:
Unit tests pass, focus is normally contained in all existing stories
🧢 Your Project: