Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly define the exports from react-stately/tag #4106

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Conversation

LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Feb 23, 2023

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

RSP

@LFDanLu LFDanLu added release small review Easy to review PR labels Feb 23, 2023
@rspbot
Copy link

rspbot commented Feb 23, 2023

@rspbot
Copy link

rspbot commented Feb 23, 2023

@rspbot
Copy link

rspbot commented Feb 23, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

@react-stately/tag

TagGroupProps

-
+TagGroupProps<T> {
+  allowsRemoving?: boolean
+  maxRows?: number
+  onRemove?: (Key) => void
+}

@LFDanLu LFDanLu merged commit c707a7b into main Feb 23, 2023
@LFDanLu LFDanLu deleted the tagstate_exports branch February 23, 2023 17:39
@dannify dannify removed the release label Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small review Easy to review PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants