fix: Changes for websites that do not redirect non www url to www url #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekremney
reviewed
May 7, 2024
src/experimentation/handler.js
Outdated
| url: finalUrl, | ||
| }; | ||
|
|
||
| const data = await rumAPIClient.getExperimentationData(params); | ||
| let data = await rumAPIClient.getExperimentationData(params); | ||
| if (data.length === 0 && !finalUrl.toLowerCase().startsWith('www')) { |
There was a problem hiding this comment.
!finalUrl.toLowerCase().startsWith('www') would also return true for sites with valid subdomains such as blog.adobe.com. We should also include it in the check, otherwise we may end up with something like www.blog.adobe.com > which is wrong
data.length === 0 && hasNonWWWSubdomain(baseURL) && !finalUrl.startsWith('www')`
There was a problem hiding this comment.
Incorporated this.
src/experimentation/handler.js
Outdated
| const data = await rumAPIClient.getExperimentationData(params); | ||
| let data = await rumAPIClient.getExperimentationData(params); | ||
| if (data.length === 0 && !finalUrl.toLowerCase().startsWith('www')) { | ||
| finalUrl = 'www.'.concat(finalUrl); |
There was a problem hiding this comment.
please use ES6 way of string concatenation:
finalUrl = `www.${finalUrl}`;
There was a problem hiding this comment.
Incorporated this.
|
This PR will trigger a patch release when merged. |
ekremney
approved these changes
May 8, 2024
solaris007
pushed a commit
that referenced
this pull request
May 8, 2024
## [1.15.8](v1.15.7...v1.15.8) (2024-05-08) ### Bug Fixes * Changes for websites that do not redirect non www url to www url ([#248](#248)) ([088ad72](088ad72))
solaris007
pushed a commit
that referenced
this pull request
May 8, 2024
## [1.15.8](v1.15.7...v1.15.8) (2024-05-08) ### Bug Fixes * Changes for websites that do not redirect non www url to www url ([#248](#248)) ([088ad72](088ad72))
|
🎉 This PR is included in version 1.15.8 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!