Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Cairo-enabled build breakage from "Add C++17 compatibility in a… #196

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixes Cairo-enabled build breakage from "Add C++17 compatibility in a… #196

wants to merge 2 commits into from

Conversation

HinTak
Copy link

@HinTak HinTak commented Feb 2, 2024 •
edited
Loading

…ddition to C++11 (#194)" commit

Commit e091851 missed a change in the cairo-related code.

Fixes #195.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@HinTak
Fixes Cairo-enabled build breakage from "Add C++17 compatibility in a…
e2d7ae5 
…ddition to C++11 (adobe#194)" commit

Commit e091851 missed a change in the cairo-related code.

Fixes adobe#195.
@HinTak HinTak closed this Feb 2, 2024
@HinTak HinTak reopened this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkschulze dirkschulze Awaiting requested review from dirkschulze dirkschulze is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cairo build breakage from recent c++17 change
1 participant
@HinTak