Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add C++17 compatibility in addition to C++11 #194

Merged
merged 10 commits into from
Jan 8, 2024
Merged

Add C++17 compatibility in addition to C++11 #194

merged 10 commits into from
Jan 8, 2024

Conversation

dirkschulze
Copy link
Member

@dirkschulze dirkschulze commented Jan 8, 2024 •
edited
Loading

Make code compatible to C++17 using std::variant

Description

C++17 introduces std::variant. Make the code compatible to C++17 and above.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dirkschulze dirkschulze changed the title [DO_NOT_REVIEW] C++17 compatibility test with VS Add C++17 compatibility in addition to C++11 Jan 8, 2024
@dirkschulze dirkschulze marked this pull request as ready for review January 8, 2024 13:35
@dirkschulze dirkschulze mentioned this pull request Jan 8, 2024
Closed
10 tasks
@dirkschulze dirkschulze merged commit e091851 into main Jan 8, 2024
7 checks passed
@dirkschulze dirkschulze deleted the cxx-17-compatible-vs-test branch January 8, 2024 15:52
HinTak added a commit to HinTak/svg-native-viewer that referenced this pull request Feb 2, 2024
@HinTak
Fixes Cairo-enabled build breakage from "Add C++17 compatibility in a…
e2d7ae5 
…ddition to C++11 (adobe#194)" commit

Commit e091851 missed a change in the cairo-related code.

Fixes adobe#195.
@HinTak HinTak mentioned this pull request Feb 2, 2024
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjindal tjindal tjindal approved these changes

@qrb7xc qrb7xc qrb7xc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dirkschulze @qrb7xc @tjindal