Fix for Issue #111: a valid fill attribute cannot override its parental "fill='none'" attribute. #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t' from kInvalid to kSuccess, all 'return result' before changing 'result' are replaced by 'return kInvalid'
dirkschulze
approved these changes
Jun 28, 2020
|
Thanks a lot @mpsuzuki ! |
|
@dirkschulze , sorry for delayed action! To work with other issues #114, #115, I've committed this change set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SVGStringParser::ParsePaint() sets the initial value of 'result' to kInvalid. In some cases, the result is updated to kDisabled, but it is never updated to kSuccess, except of the case that ParseColor() updates it. Therefore, once the parental element sets "fill='none'", often the child elements cannot override it, like Issue #111.
This commit changes the initial value from kInvalid to kSuccess, and all 'return result' before changing 'result' are replaced by immediate 'return kInvalid'.