Rearrange analytics extension fields to use nested structure #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cmathis, @jwen-adobe can you check this out and make sure it continues to work with our tooling? |
|
@kstreeter It works well with the tooling. |
|
Looking at this, one aspect we are realizing is that extensions should generally be organized into grouping fields in the hierarchy rather then over populating the root nodes of the schemas they are extending. |
|
We should do this same thing to #302. |
trieloff
approved these changes
May 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the Analytics extension fields into nested objects, versus having them organized with distinct namespaces.
Please link to the issue #…
This is one of the issues described in #277.