📝 Clarify CLA section of contribution guidelines. #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeschbe
reviewed
Jun 12, 2018
CONTRIBUTING.md
Outdated
| @@ -33,7 +33,7 @@ Where possible, include the Creative Commons Attribution 4.0 International (CC B | |||
|
|
|||
| ### Contributor License Agreement | |||
|
|
|||
| All third-party contributions to this project must be accompanied by a signed contributor license. This gives Adobe permission to redistribute your contributions as part of the project. Sign our CLA at [http://opensource.adobe.com/cla.html](http://opensource.adobe.com/cla.html). You only need to submit an Adobe CLA one time, so if you have submitted one | |||
| All third-party contributions to this project must be accompanied by a signed contributor license. This gives Adobe permission to redistribute your contributions as part of the project. [Sign our CLA ](http://opensource.adobe.com/cla.html)! You only need to submit an [Adobe CLA](http://opensource.adobe.com/cla.html) one time. | |||
There was a problem hiding this comment.
I would omit the first change since I prefer to have the URL in the open an visible as opposed to hide it behind a link in a three-word "order".
+1 on the change to the second sentence which seems incomplete before the change
|
Thanks for the review @fmeschbe, I've reverted the first change as per your request. |
|
I am going to merge this PR to include it in the 0.9.3 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLA section weirdly cuts off at the end. It is a small thing 🌱