Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue409-Fix campaign extension bugs #410

Merged
merged 3 commits into from
Jun 26, 2018

Conversation

jwen-adobe
Copy link
Contributor

This PR links to the issue #409

@kstreeter @trieloff @chrisdegroot @cmathis

Please review and approve at earliest convenience as this bug failed the registry publish during 0.9.9.2 deployment.

  • removed $ref which referenced non-existing schema
  • change ‘allof’ to ‘allOf’

- removed $ref which referenced non-existing schema
- change ‘allof’ to ‘allOf’
Copy link
Contributor

@cdegroot-adobe cdegroot-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve. We are going to have to implement a strict validation checker.

@kstreeter kstreeter merged commit fb7410e into master Jun 26, 2018
@jwen-adobe jwen-adobe deleted the issue409-fix-campaign-extension-bugs branch June 26, 2018 23:23
@fmeschbe fmeschbe added the v0.9.3 Scheduled for v0.9.3 label Jul 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v0.9.3 Scheduled for v0.9.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants