Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Video analytics final updates august #433

Merged

Conversation

cdegroot-adobe
Copy link
Contributor

WIP holding the properties that could not reach closure for the Video Analytics PR in July.

airDate
digitalDate
mediaSegments
bitrateAverageBucket

Cosmin Ciobanu and others added 30 commits June 15, 2018 11:05
* no metric definitions
* no metric definitions
sdk->playerSDK
removed vhl to put it in a different branch/PR as a vendor extension.
Schema count is now 208
Merge branch 'final-PR-to-Adobe-WG' of 
https://github.com/cdegroot-adobe/xdm-1 into final-PR-to-Adobe-WG
corrected 2id definition with a "format": "uri",
Improved description
@fmeschbe
Copy link
Collaborator

Tracked by issue #435

@fmeschbe fmeschbe merged commit 8464282 into adobe:master Jul 14, 2018
@fmeschbe fmeschbe added v0.9.4 Scheduled for v0.9.4 and removed v0.9.4 Scheduled for v0.9.4 labels Jul 14, 2018
@fmeschbe
Copy link
Collaborator

@cdegroot-adobe there is some thing strange with this PR: It shows as merged but I don't think it really is merged. Particularly the elements intended to be part of this PR are not in master even after this showing merged. Also the code history of master does not show this PR merged. This is very strange ...

Maybe we'd have to respin this PR from scratch ?

@cdegroot-adobe
Copy link
Contributor Author

@fmeschbe - This PR is not to be merged, it is a WIP for resolution in August. Can you roll this one back out please. It should not be part of 0.9.3.

The other Video Analytics one looks like it was merged fine.

Thanks C.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants