Correct profile stitching #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kstreeter, Can we get this merged in as a correction? |
First error: Accidentally replaced reference to profile stitching in segment membership with Identity array instead of modifying profile stitch Second error: Didn't have profile stitching as an array. It was only an array in the examples, but that got "corrected" to match the schema.
harleensahni
force-pushed
the
correct-profile-stitching
branch
from
55f64a1 to
931b0fe
Compare
remove new line between description key and description
|
FYI - This creates a breaking change to the schema which affects any EE data that was previously ingested from Analytics or Campaign. Doing this will require everyone to throw away data and start over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two issues with the PR I created for profile stitching (#444 ) that weren't caught till now.
Profile stitching on experience event should be an array of profile stitching entities, not a single profile stitch. The example was right before, but that was corrected to match the incorrect schema.
Also, move to use Identity array in profile stitch. It was incorrectly put in segment membership instead due to some sloppy copy and pasting.