Issue 516 - Removing minLength constraint on measure ids #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jwen-adobe - Looks like you added this originally, do you remember a reason? |
|
@chrisdegroot After digging the change log, I do see I made the change specifically. Frankly, I do not recall any reasons for that though unless @cmathis remembered anything, or maybe someone suggested me do that. |
|
No idea. I say we remove it and include it with the 0.9.6 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #516. The
measureschema has a constraint on it that requires the ID of the measure to be at least 20 chars. This has caused some confusion in cases where a shorter identifier was available but could not be used due to the constraint.I actually don't recall why the constraint was added in the first place. @trieloff or @cdegroot-adobe do you recall?