Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[543] Added xdm:localTimezoneOffset to context/placecontext #544

Merged
merged 1 commit into from
Oct 30, 2018
Merged

[543] Added xdm:localTimezoneOffset to context/placecontext #544

merged 1 commit into from
Oct 30, 2018

Conversation

cluby-adobe
Copy link
Contributor

@cluby-adobe cluby-adobe commented Oct 25, 2018

@kstreeter
Copy link
Collaborator

Hey @cluby-adobe this addition makes sense, but would it make sense to make the offset a string that has the same form of the offset defined in ISO8601? This definition seems to be what they do in Javascript, but in Java they appear to support the string form.

@cluby-adobe
Copy link
Contributor Author

@cluby-adobe, The issue is we don't know the actual timezone. We only have the current offset.

@kstreeter
Copy link
Collaborator

Understood we would not have the actual timezone, just the offset. ISO8601 has a notation for that (a "-" followed by the HH:MM of the offset). That notation appears to be supported at least in the Java environment.

@cluby-adobe
Copy link
Contributor Author

@kstreeter, Do you know of anything that tries to use this format for timezone offset on it's own outside of a date-time string? I want to make sure there is value in using this format to justify the cost of dealing with in at various layers. If every layer is just going to have to convert it into minutes to use it why don't we just represent it as minutes.

@kstreeter kstreeter merged commit ae66352 into adobe:master Oct 30, 2018
@kstreeter kstreeter added this to the 0.9.7 milestone Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants