Added dcx JSON-LD prefix definition & dcx:type property to the meta schema #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogoldman
requested changes
Nov 6, 2018
meta.schema.json
Outdated
| @@ -125,6 +125,12 @@ | |||
| "title": { | |||
| "type": "string", | |||
| "minLength": 3 | |||
| }, | |||
| "dcx:type": { | |||
There was a problem hiding this comment.
Suggest we call this "dcx:typeRestriction". It's not a media type in the same sense as dc:format, or the "type" format in the DCX manifest, but simply calling it "dcx:type" suggest that it is.
There was a problem hiding this comment.
Agree, I've made this change now.
|
looks like you are good with this one @ogoldman? |
ogoldman
approved these changes
Nov 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No Issue filed for this yet.
After we write DCX schemas, before we use one of those schemas we want to know what DCX format the schema applies to, hence the need to introduce the dcx:type property in the meta schema.