Additional descriptor attributes #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will use the meta:enum to add both the enum and meta:enum to the field.
khanna-vikas
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding additional attributes to the alternate name descriptor which can be used to add additional meta:enum values to a standard field. Registry will apply this descriptor when the schema is requested.
Note that meta:enum does not add constraints like the normal "enum" does. This is simply to add additional meta-data used by the UI to provide a drop-down of potential values. If the field does NOT have an associated "enum", then the UI drop-down must provide an "other" option which then provides a text box where the user can supply the other value.