Add property 'locale' to Environment. #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The locale property is used to state the language of the environment.
lrosenthol
requested changes
Mar 17, 2020
| @@ -137,6 +137,16 @@ | |||
| "title": "Internet service provider", | |||
| "type": "string", | |||
| "description": "The name of the user's internet service provider." | |||
| }, | |||
| "xdm:locale": { | |||
There was a problem hiding this comment.
You don't need this since XDM is valid JSON-LD, you should be using the standard @language value.
| @@ -240,6 +242,33 @@ The numerical label assigned to a device participating in a computer network tha | |||
|
|
|||
|
|
|||
|
|
|||
| ## xdm:locale | |||
There was a problem hiding this comment.
See comments as to why this is unnecessary
| @@ -143,6 +143,16 @@ | |||
| "title": "Internet service provider", | |||
| "type": "string", | |||
| "description": "The name of the user's internet service provider." | |||
| }, | |||
There was a problem hiding this comment.
See comments about why you don't need this.
Representation of locale codes is already provided by the Dublin Core term 'language' so it should be used here instead of creating a new XDM property.
|
@lrosenthol Thanks for your feedback. I've updated this PR to use |
cmathis
approved these changes
Apr 3, 2020
khanna-vikas
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding property 'locale' to the Environment schema to state the language of the environment at the time of the event. The locale code should follow RFC BCP 47
Change requested by Mobile SDK as 'locale' is an environment metric sent to Analytics in application lifecycle events.