Person mixin and person name updates #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--added mailing address to Address Mixin --new field added to person-name datatype called "suffix" --new fields added to pesron mixin (maritalStatus, nationality, taxId)
corrected birth year as int instead of string
lrosenthol
requested changes
Apr 13, 2020
--fixed example --updated marital status enum options and added pattern for nationality
--nationality field updated from 3 digit to 2 digit ISO 3166-1 standard
--updated nationality value reflect two digit ISO 3166-1 code
cmathis
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--added mailing address to Address Mixin
--new field added to person-name datatype called "suffix"
--new fields added to pesron mixin (maritalStatus, nationality, taxId)