Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leaks when returning strings from C++ to Rust #104

Merged
merged 2 commits into from
Oct 22, 2022

Conversation

scouten-adobe
Copy link
Member

Changes in this pull request

Fixes #102.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@scouten-adobe scouten-adobe self-assigned this Oct 22, 2022
@codecov
Copy link

codecov bot commented Oct 22, 2022

Codecov Report

Merging #104 (63c818c) into main (c697230) will increase coverage by 0.15%.
The diff coverage is 96.96%.

@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   95.73%   95.89%   +0.15%     
==========================================
  Files           7        7              
  Lines         704      730      +26     
==========================================
+ Hits          674      700      +26     
  Misses         30       30              
Impacted Files Coverage Δ
src/xmp_date_time.rs 97.50% <66.66%> (-0.10%) ⬇️
src/ffi.rs 100.00% <100.00%> (ø)
src/xmp_meta.rs 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@scouten-adobe scouten-adobe merged commit c53d4a0 into main Oct 22, 2022
@scouten-adobe scouten-adobe deleted the fix-memory-mgmt branch October 22, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FFI functions likely leak strings returned from C code
1 participant