Fix broken documentation build #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #67 +/- ##
=======================================
Coverage 87.98% 87.98%
=======================================
Files 6 6
Lines 233 233
=======================================
Hits 205 205
Misses 28 28 Continue to review full report at Codecov.
|
3 tasks
scouten-adobe
added a commit
to contentauth/c2pa-rs
that referenced
this pull request
Jul 14, 2022
Release 0.7.1 [failed to build on docs.rs](https://docs.rs/crate/c2pa/0.7.1) because the so-called "no-op" C++ code in XMP Toolkit contained a reference to a field that was disabled elsewhere. (See adobe/xmp-toolkit-rs#67.) This PR incorporates the fixed version of XMP Toolkit and and updates the PR validation loop to more closely mimic the docs.rs runtime environment so we detect future errors of this type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Release 0.5.0 failed to build on docs.rs because the so-called "no-op" C++ code contained a reference to a field that was disabled elsewhere.
This PR fixes the unwanted field reference in the
NOOP_FFIcase and updates the PR validation loop to more closely mimic the docs.rs runtime environment so we detect future errors of this type.Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.