Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MINOR) Refactor how property values are returned from accessor functions #81

Merged
merged 4 commits into from
Oct 12, 2022

Conversation

scouten-adobe
Copy link
Member

Changes in this pull request

Introduces XmpValue as a templated type with accessors for the various flags that the C++ XMP Toolkit can return.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

…ions

Introduces `XmpValue` as a templated type with accessors for the various flags that the C++ XMP Toolkit can return.
@scouten-adobe scouten-adobe self-assigned this Oct 12, 2022
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #81 (775ef6c) into main (4f3f10e) will increase coverage by 1.77%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   89.96%   91.74%   +1.77%     
==========================================
  Files           6        7       +1     
  Lines         279      339      +60     
==========================================
+ Hits          251      311      +60     
  Misses         28       28              
Impacted Files Coverage Δ
src/ffi.rs 100.00% <ø> (ø)
src/lib.rs 100.00% <ø> (ø)
src/xmp_meta.rs 100.00% <100.00%> (ø)
src/xmp_value.rs 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

That makes writing tests ever so much easier …
This allows it to pass through the various "option" flags that C++ XMP Toolkit provides.
@scouten-adobe scouten-adobe merged commit 0634185 into main Oct 12, 2022
@scouten-adobe scouten-adobe deleted the xmp-value-refactor branch October 12, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant