Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typed property getters #94

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Add typed property getters #94

merged 1 commit into from
Oct 21, 2022

Conversation

scouten-adobe
Copy link
Member

Changes in this pull request

This adds typed property getters that use the underlying C++ code to parse property values as bool, i32, i64, f64, and XmpDateTime values.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@scouten-adobe scouten-adobe self-assigned this Oct 21, 2022
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #94 (8622b70) into main (0d6481c) will increase coverage by 1.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
+ Coverage   93.84%   94.98%   +1.13%     
==========================================
  Files           7        7              
  Lines         455      558     +103     
==========================================
+ Hits          427      530     +103     
  Misses         28       28              
Impacted Files Coverage Δ
src/ffi.rs 100.00% <ø> (ø)
src/xmp_meta.rs 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@scouten-adobe scouten-adobe merged commit c56d848 into main Oct 21, 2022
@scouten-adobe scouten-adobe deleted the typed-property-getters branch October 21, 2022 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant