fix: clearing slash prefixes before adding uriSegment within url builder's processPattern #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes v6 issue 48, by stripping slashes prior to adding
uriSegment
withinproccessPattern
.Changes this:
To this:
Added two new tests as well to cover this noted issue within
tests/router/url_builder.spec.ts
:Types of changes
What types of changes does your code introduce?
Checklist
Further comments
Doesn't look like
npm commit
exists yet in thenext
branch, so I went ahead and just usedgit commit
. If you need anything changed, just let me know 😊