Merge pull request #65 from targos/fix-sprintf-v4

fix: support falsy value in sprintf substitution
adonisjs · Feb 8, 2024 · 7d8593e · 7d8593e
2 parents d77c024 + b40a9c7
commit 7d8593e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/src/Logger.ts b/src/Logger.ts
@@ -119,13 +119,7 @@ export class Logger implements LoggerContract {
   public log(level: string, message: string, ...values: any[]): void
   public log(level: string, mergingObject: any, message: string, ...values: any[]): void
   public log(level: string, mergingObject: any, message: string, ...values: any[]): void {
-    if (values.length) {
-      this.pino[level](mergingObject, message, ...values)
-    } else if (message) {
-      this.pino[level](mergingObject, message)
-    } else {
-      this.pino[level](mergingObject)
-    }
+    this.pino[level](mergingObject, message, ...values)
   }
 
   /**

diff --git a/test/logger.spec.ts b/test/logger.spec.ts
@@ -90,6 +90,7 @@ test.group('Logger', () => {
     logger.info('hello %s', 'info')
     logger.info('hello %s %o', 'info', { url: '/' })
     logger.info('hello %s %j', 'info', { url: '/' })
+    logger.info('total: %d', 0)
 
     assert.deepEqual(
       messages.map((m) => {
@@ -109,6 +110,10 @@ test.group('Logger', () => {
           level: 30,
           msg: `hello info ${JSON.stringify({ url: '/' })}`,
         },
+        {
+          level: 30,
+          msg: 'total: 0',
+        },
       ]
     )
   })